New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown - Multiselect - Refactor/Redesign #74

Closed

meissadia opened this issue Jun 8, 2023 · 1 comment · Fixed by #104

Assignees

Labels

Contributor

meissadia commented Jun 8, 2023 •

edited

Add a prop to display the pills below, as opposed to above, the dropdown

Contributor Author

meissadia commented Jun 27, 2023

@the-raft-oar already implemented option for displaying pills below.

Next step is to implement the adjusted pill stylings as seen in the screenshot above.

Questions:

Do we implement this change in the React component or wait until there are usable styles in the design system?
Broader question: Dropdown currently implemented with react-select lib. Do we want to revisit using the design system components?
Always include the selected label? Make label customizable?
Always vertical? Make orientation customizable?
If shown above, use the same style? Or fall back to the horizontal w/o label?

meissadia changed the title ~~Dropdown - Multiselect - Pills below~~ Dropdown - Multiselect - Refactor/Redesign

meissadia mentioned this issue

74 dropdown redesign #104

Merged

meissadia self-assigned this

contolini closed this as completed in #104

meissadia added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment