Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74 dropdown redesign #104

Merged
merged 11 commits into from
Jul 27, 2023
Merged

74 dropdown redesign #104

merged 11 commits into from
Jul 27, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jul 13, 2023

Updates to components to support the scenarios needed for the Complete User Profile page.

Closes #74

Changes

  • Dropdown
    • Updates styling of pills
    • Allows customization of pill display location and hiding them
    • Allows display of checkbox next to dropdown options
    • Allow a 'Clear All' button to quickly clear selections
  • Icon
    • Display with or without background
    • Support propagation of all supported HTML props
  • Label
    • Hide if no label text provided
  • Notification
    • Enable show/hide via props
    • Enable show/hide icon via props
  • [New] Divider component to provide a horizontal rule
  • Page Header
    • Remove unnecessary margin
  • Well
    • Code cleanup

How to test this PR

  1. Open the Netlify preview
  2. Visit the Dropdown, Icon, Label stories
  3. See if things look sensible

Notes

  • I hate typescript

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 90c6fc7
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64c025d22cee300008d54df4
😎 Deploy Preview https://deploy-preview-104--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@contolini contolini enabled auto-merge (squash) July 27, 2023 15:31
@contolini contolini merged commit 0512196 into main Jul 27, 2023
9 of 10 checks passed
@contolini contolini deleted the 74-dropdown-redesign branch July 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown - Multiselect - Refactor/Redesign
2 participants