Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interaction Tests] ExpandableGroup #101

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jun 30, 2023

Closes #36

Changes

  • Expands on James' interaction testing to get them pass consistently on page load

How to test this PR

  1. Open preview
  2. Go to ExpandableGroup - default
  3. Reload page to verify interaction test run successfully on load

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 2a98a3c
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/649f43fc154f4a000a69d6f8
😎 Deploy Preview https://deploy-preview-101--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia changed the title 36 add expandable tests [Interaction Tests] ExpandableGroup Jun 30, 2023
@meissadia meissadia changed the title [Interaction Tests] ExpandableGroup [Interaction Tests] Expandable and ExpandableGroup Jun 30, 2023
@meissadia meissadia changed the title [Interaction Tests] Expandable and ExpandableGroup [Interaction Tests] ExpandableGroup Jun 30, 2023
@meissadia meissadia marked this pull request as ready for review June 30, 2023 19:52
@contolini contolini enabled auto-merge (squash) June 30, 2023 21:13
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@contolini contolini merged commit 5b67a5b into main Jun 30, 2023
6 checks passed
@contolini contolini deleted the 36-add-expandable-tests branch June 30, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for ExpandableGroup component
3 participants