Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Banner] Propagate attributes #114

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[Banner] Propagate attributes #114

merged 2 commits into from
Aug 9, 2023

Conversation

meissadia
Copy link
Contributor

Closes #113

  • Integrate passed className into class derivation logic
  • update tests

How to test this PR

  1. yarn && yarn start
  2. yarn vitest Banner

Note: Test says Tagline line 14 is untested but there is a specific test for that piece of code....so not sure what's going on there.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 8749080
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64cc25737c3f6800081fd0f6
😎 Deploy Preview https://deploy-preview-114--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia enabled auto-merge (squash) August 3, 2023 22:08
@meissadia meissadia merged commit d42a349 into main Aug 9, 2023
10 checks passed
@meissadia meissadia deleted the 113-banner-propagate branch August 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Banner] Propagate all supported properties to underlying HTML elements
2 participants