[Component] Verify TextInput Component #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Moved the Label component into the verified state - Changed various references to use Label instead of label
Changes: - Simplified the TextInput component to an atom, removed baked-in Notification - Updated Storybook description to match CFPB design - Updated Storybook stories to match CFPB TextInput examples
shindigira
requested review from
meissadia and
billhimmelsbach
as code owners
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shindigira
changed the title
meissadia
reviewed
Nov 28, 2023
meissadia
reviewed
Nov 28, 2023
meissadia
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Missing the Button inside text input with another button story, was this intentionally excluded?
Updated. |
meissadia
requested changes
Dec 1, 2023
meissadia
approved these changes
Dec 4, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
Changes
Verification Checklist
See #239 For Verification Checklist
Accessibility Tests (WAVE)
How to test this PR
yarn test TextInputScreenshots