Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visual Testing] Chromatic - Initial Github action integration #29

Merged
merged 4 commits into from
Jul 10, 2023
Merged

[Visual Testing] Chromatic - Initial Github action integration #29

merged 4 commits into from
Jul 10, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Apr 19, 2023 •
edited by contolini
Loading

Closes #23

Initial Github action integration

TODO

@netlify
Copy link

netlify bot commented Apr 19, 2023 •
edited
Loading

✅ Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 4a16d7d
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64ac27fcf4a13c000842d770
😎 Deploy Preview https://deploy-preview-29--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia mentioned this pull request Apr 19, 2023
Closed
3 tasks
@meissadia meissadia force-pushed the visual-testing-chromatic branch 4 times, most recently from 6f684a9 to 149a122 Compare April 20, 2023 18:01
@contolini contolini force-pushed the visual-testing-chromatic branch 2 times, most recently from b822846 to 3cd4a5b Compare July 10, 2023 15:08
@contolini contolini self-requested a review July 10, 2023 19:24
contolini
contolini approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Gonna merge this and check the UI review workflow in subsequent PRs.

@contolini contolini marked this pull request as ready for review July 10, 2023 19:25
@contolini contolini merged commit 783a57f into main Jul 10, 2023
10 checks passed
@contolini contolini deleted the visual-testing-chromatic branch July 10, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up visual regression tests
2 participants
@meissadia @contolini