-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node 20 | Update to yarn 4.1.0 #314
Conversation
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the .nvmrc
file to lts/iron
to specify v20. Netlify is failing because it's still trying to build with v16 (gallium)
The yarn docs are kinda confusing but when they say "custom pre and post scripts are no longer supported" they mean putting the word Yarn still supports some standard scripts that include the FWIW, the reason this repo has a prepack script is because it's run by the SBL frontend after it downloads this library directly from github:
|
Thanks @contolini ! I updated this in f5a107d Is there some reason why we shouldn't put the actual version number in there? |
|
Changes
How to test this PR
yarn install
should pass.Screenshots
Notes
.npmrc
is ignored, according to https://yarnpkg.com/migration/guideyarn prepack
would be run, but the functionality for it to automatically run does not exist any longer. See https://yarnpkg.com/migration/guide#update-your-configuration-to-the-new-settings