Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 | Update to yarn 4.1.0 #314

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

anselmbradford
Copy link
Member

Changes

  • Update to yarn 4.1.0
  • Update to node 20

How to test this PR

  1. yarn install should pass.

Screenshots

Notes

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 01e5574
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65e0be1c46620b0008afcf28
😎 Deploy Preview https://deploy-preview-314--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the .nvmrc file to lts/iron to specify v20. Netlify is failing because it's still trying to build with v16 (gallium)

@contolini
Copy link
Member

The yarn docs are kinda confusing but when they say "custom pre and post scripts are no longer supported" they mean putting the word pre in front of any random script name. E.g. if you have a script called lint, you used to be able to create another one called prelint and it would automatically run before lint.

Yarn still supports some standard scripts that include the pre prefix, like prepack and prepublish.

FWIW, the reason this repo has a prepack script is because it's run by the SBL frontend after it downloads this library directly from github:

Each time Yarn has to fetch a dependency from a "raw" source (such as a Git repository), it will automatically run yarn install and yarn pack to generate the package to use.

@anselmbradford
Copy link
Member Author

Update the .nvmrc file to lts/iron to specify v20. Netlify is failing because it's still trying to build with v16 (gallium)

Thanks @contolini ! I updated this in f5a107d

Is there some reason why we shouldn't put the actual version number in there? v20 like we do in cfgov https://github.com/cfpb/consumerfinance.gov/blob/main/.nvmrc

@contolini
Copy link
Member

v20 is fine by me!

contolini
contolini previously approved these changes Feb 28, 2024
@anselmbradford anselmbradford merged commit 34b6e66 into main Feb 29, 2024
7 of 9 checks passed
@anselmbradford anselmbradford deleted the ans_yarn_node branch February 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants