feat: Restructure components to live in their own separate folders #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-stories ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
contolini
reviewed
Jun 8, 2023
| @@ -1,6 +1,6 @@ | |||
| import type { Meta, StoryObj } from '@storybook/react'; | |||
| import type { SyntheticEvent } from 'react'; | |||
| import { Banner } from './Banner'; | |||
| import { Banner } from '.'; | |||
There was a problem hiding this comment.
Thanks for reorganizing everything! Curious: Is there any advantage to renaming the components to index.tsx? I kind of prefer the more verbose Component.tsx filename because it makes it easier to find the file in my text editor.
There was a problem hiding this comment.
Brevity is probably the main win there. import { Banner } from './Banner/Banner.tsx' felt excessive but I'm fine with prioritizing dev experience.
I will update these names.
contolini
reviewed
Jun 15, 2023
Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
contolini
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Changes
How to test this PR
yarn test-> all look good