Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop to align pills to the bottom #89

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

the-raft-oar
Copy link
Contributor

[Short description explaining the high-level reason for the pull request]

Changes

  • Add prop to align pills to the bottom

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 081b332
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/6493557101441d0008342ecd
😎 Deploy Preview https://deploy-preview-89--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@contolini
Copy link
Member

Looking good! The CSS may need to be adjusted to accommodate lots of pills. The spacing under the dropdown collapses when the pills break to a new line:

without break with break
image image

@contolini
Copy link
Member

And how do y'all want to support the ability to add a label (e.g. Selected)? Seems like it might be a feature unrelated to the pill placement. I'll make a separate issue for it.

image

src/components/Dropdown/DropdownPills.less Outdated Show resolved Hide resolved
src/components/Dropdown/DropdownPills.tsx Outdated Show resolved Hide resolved
the-raft-oar and others added 3 commits June 21, 2023 15:53
Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
@contolini contolini merged commit 05bef37 into main Jun 21, 2023
6 checks passed
@contolini contolini deleted the 74-dropdown-pills branch June 21, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants