Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project file structure #55

Closed
imuchnik opened this issue Jun 11, 2015 · 7 comments
Closed

Project file structure #55

imuchnik opened this issue Jun 11, 2015 · 7 comments

Comments

@imuchnik
Copy link
Member

I have noticed a strong affinity to putting everything in app.js or main.js. While it keeps things tidy and intuitively in one place, it does very little for project clarity. How does everyone feel about arriving at some more standardized project structure and smaller, well named files?

@ascott1
Copy link
Member

ascott1 commented Jun 11, 2015

In a lot of cases the main.js or app.js file is a bundled file from all of our modules. I do think we should have some sort of naming convention. For eRegulations we bundle everything into regulations.js. Should we start by auditing the current file production names?

Also, I think it would be really useful to have guidelines on structuring the modules in our projects. Those can vary wildly from project to project and depending on the framework (or lack thereof).

@cfarm
Copy link
Contributor

cfarm commented Jul 17, 2015

yes to better file structure! I like a modules/plugins/libraries folder structure:

/js/
  libraries/
  modules/
  plugins/

for file names, either camelCase or hyphen separated but it should be consistent.

@Scotchester
Copy link
Contributor

n00b question: What is the difference between libraries, modules, and plugins?

@imuchnik
Copy link
Member Author

If you chose a framework for your project, stay within its conventions. Otherwise, do something stupid obvious, like @cfarm example above or even simpler

/js/
  source/
  test/
  third-party/

Avoid deep nested structures or overly vague and overused names- e.g -'static'.

@ascott1
Copy link
Member

ascott1 commented Feb 29, 2016

We seem to have, mostly, settled on the file structure that the generator produces. Does this need to be documented further?

KimberlyMunoz added a commit that referenced this issue Feb 29, 2016
Added a quick note so a new FEWD knows what the generator is for. This should be sufficient for #55.
@KimberlyMunoz
Copy link
Contributor

I just added a quick note to the Readme to better introduce the generator. I think it's a nice addition for FEWDs, but that anything more than that can become outdated or redundant.

@ascott1
Copy link
Member

ascott1 commented Mar 1, 2016

👍 Perfect, thanks @KimberlyMunoz!

@ascott1 ascott1 closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants