Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Migrate icons to SVG #26

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Migrate icons to SVG #26

merged 3 commits into from
Jun 12, 2019

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Jun 12, 2019

Additions

  • Add issue and pull request templates.

Removals

  • Remove cfpb_icon_font CSS references.

Changes

  • Convert round numbered list image icons to pure CSS.
  • Convert round check, plus, and minus icons to SVG icons.
  • Convert share icons to SVG.
  • Add padding to paragraph that was missing it on the landing page (see screenshot).

Testing

  • With this repo and branch cloned into a sibling directory to cfgov-refresh, run pip install -e ../django-college-costs-comparison
  • Visit /paying-for-college/ URLs and compare to production. There are still some image icons, but some should be converted to SVG or pure CSS.

Screenshots

Before:
Screen Shot 2019-06-12 at 11 26 59 AM

After:
Screen Shot 2019-06-12 at 11 26 50 AM

Before:
Screen Shot 2019-06-12 at 3 23 31 PM

After:
Screen Shot 2019-06-12 at 3 23 17 PM

Before:
Screen Shot 2019-06-12 at 3 23 26 PM

After:
Screen Shot 2019-06-12 at 3 24 56 PM

Before:
Screen Shot 2019-06-12 at 3 34 39 PM

After:
Screen Shot 2019-06-12 at 3 34 54 PM

Notes

  • I didn't convert image icons that are not in the SVG icon set and these icons are now positioned differently from production, however, they are left-aligned with no padding on production, so this is perhaps slightly better.

Screen Shot 2019-06-12 at 3 22 07 PM

@anselmbradford anselmbradford merged commit f0ec1a4 into master Jun 12, 2019
@anselmbradford anselmbradford deleted the ans_migrate_icons branch June 12, 2019 19:42
Scotchester pushed a commit that referenced this pull request Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants