Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Validate "path matches" conditions as regular expressions
Because "path matches" conditions can be any valid regular expression, this change simply uses `re.compile()` to validate them. Previously they were validated as URL paths, without querystring or URL scheme-matching characters allowed. This warned on some valid regular expressions that it shouldn't have. This fix is what @chosak suggested in #77.
- Loading branch information
1 parent
6c70ee1
commit 71b8d02
Showing
5 changed files
with
28 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,6 @@ | |
validate_boolean, | ||
validate_date, | ||
validate_parameter, | ||
validate_path, | ||
validate_path_re, | ||
validate_user, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters