New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document how flags can be toggled in tests #122
Conversation
@willbarton I think a maintainer needs to do something for GHA to run 🙇🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dimaqq!
How would you feel about simplifying the language and structure a bit and adding this to usage.md
instead of its of own file? I think this is important to call out as general usage, because folks should be writing tests! I have another suggestion about to simplify it below.
If you don't want to put this in usage.md
, then the new file will need to be added to mkdocs.yml
to appear in the documentation.
Co-authored-by: Will Barton <will@brtns.com>
Makes sense, I've committed your suggestion. |
Re: usage, I guess the first block, the simple case could be moved to usage 🤔 |
Co-authored-by: Will Barton <will@brtns.com>
Co-authored-by: Will Barton <will@brtns.com>
suggestions have been added, thank you :) |
@willbarton wdyt, is it mergeable now? |
@dimaqq Correct, only maintainers can merge PRs. That's kind of basic PR security ;) Yes, it looks good. I'll get it merged! |
Document how flags can be toggled in tests
#121