Raise MiddlewareNotUsed in deprecated FlagConditionsMiddleware #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the [Django documentation](https://docs.djangoproject.com/en/2.2/topics/http/middleware/#marking-middleware-as-unused) on marking middle as unused, this change raises `MiddlewareNotUsed` when initializing the deprecated `FlagConditionsMiddleware`. This way, Django takes the middleware out of the middleware process and the fact that this middleware no longer calls `get_response` and returns it for a request will not interrupt the flow of the request through other middleware or to the user. This allows us to get rid of the `__call__` noop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Django documentation on marking middle as unused, this change raises
MiddlewareNotUsedwhen initializing the deprecatedFlagConditionsMiddleware. This way, Django takes the middleware out of the middleware process and the fact that this middleware no longer callsget_responseand returns it for a request will not interrupt the flow of the request through other middleware or to the user.This allows us to get rid of the
__call__noop.