Updates to support isort 5.0 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `not_skip` and `recursive` from `tox.ini` to fix TypeError: __init__() got an unexpected keyword argument 'not_skip' * recursive Prior to version 5.0.0, isort wouldn't automatically traverse directories. The --recursive option was necessary to tell it to do so. In 5.0.0 directories are automatically traversed for all Python files, and as such this option is no longer necessary and should simply be removed. * not_skip In an earlier version isort had a default skip of __init__.py. To get around that many projects wanted a way to not skip __init__.py or any other files that were automatically skipped in the future by isort. isort no longer has any default skips, so if the value here is __init__.py you can simply remove the setting. https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/
isort seems to have switched to `frozenset` for `known_standard_library`, which broke the way we're overriding it here to add `six`. This caused only `six` to be recognized as a standard library, and everything else as third-party. This is an explicit behavior change (see PyCQA/isort#1238). We no longer use `six` so we can remove this setting
Scotchester
reviewed
Jul 14, 2020
Scotchester
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
not_skipandrecursivefromtox.inito fixTypeError: init() got an unexpected keyword argument 'not_skip'
recursive
Prior to version 5.0.0, isort wouldn't automatically traverse directories. The --recursive option was necessary to tell it to do so. In 5.0.0 directories are automatically traversed for all Python files, and as such this option is no longer necessary and should simply be removed.
not_skip
In an earlier version isort had a default skip of init.py. To get around that many projects wanted a way to not skip init.py or any other files that were automatically skipped in the future by isort. isort no longer has any default skips, so if the value here is init.py you can simply remove the setting.
https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/
Short description explaining the high-level reason for the pull request
Checklist