Validate "path matches" conditions as regular expressions

docs/releasenotes.md

@@ -1,5 +1,12 @@
 # Release Notes
 
+## Unreleased
+
+### What's new?
+
+- Fixed the "path matches" condition validator to allow any valid regular expression.
+
+
 ## 5.0.3
 
 ### What's new?

flags/conditions/__init__.py

@@ -20,6 +20,6 @@
     validate_boolean,
     validate_date,
     validate_parameter,
-    validate_path,
+    validate_path_re,
     validate_user,
 )

flags/conditions/conditions.py

@@ -9,7 +9,7 @@
     validate_boolean,
     validate_date,
     validate_parameter,
-    validate_path,
+    validate_path_re,
     validate_user,
 )
 
@@ -67,7 +67,7 @@ def parameter_condition(param_name, request=None, **kwargs):
     return request.GET.get(param_name) == param_value
 
 
-@register("path matches", validator=validate_path)
+@register("path matches", validator=validate_path_re)
 def path_condition(pattern, request=None, **kwargs):
     """ Does the request's path match the given regular expression? """
     if request is None:

flags/conditions/validators.py

@@ -7,22 +7,23 @@
 from django.utils import dateparse
 
 
-validate_path = RegexValidator(
-    re.compile(r"^[^\s:?#]+$", re.UNICODE),
-    message=(
-        "Enter a valid path without a URL scheme, query string, or fragment."
-    ),
-    code="invalid",
-)
-
-
 validate_parameter = RegexValidator(
     re.compile(r"^[-_\w=]+$", re.UNICODE),
     message="Enter a valid HTTP parameter name.",
     code="invalid",
 )
 
 
+def validate_path_re(value):
+    try:
+        re.compile(value)
+    except re.error as e:
+        raise ValidationError(
+            "Enter either a valid path or a regular expression to match a "
+            "path, without a URL scheme, query string, or fragment."
+        ) from e
+
+
 def validate_boolean(value):
     message = "Enter one of 'on', 'off', 'true', 'false', etc."
     try:

flags/tests/test_conditions_validators.py

@@ -6,7 +6,7 @@
     validate_boolean,
     validate_date,
     validate_parameter,
-    validate_path,
+    validate_path_re,
     validate_user,
 )
 
@@ -26,18 +26,15 @@ def test_valid_parameter_strings(self):
 
 
 class ValidatePathTestCase(TestCase):
-    def test_invalid_path_strings(self):
+    def test_invalid_path_regexs(self):
         with self.assertRaises(ValidationError):
-            validate_path("/my/path#foo")
-        with self.assertRaises(ValidationError):
-            validate_path("/my/path?foo=bar")
-        with self.assertRaises(ValidationError):
-            validate_path("https://foo/my/path")
+            validate_path_re("*foo/my/path")
 
-    def test_valid_path_strings(self):
-        validate_path("/my/path")
-        validate_path("/my/path/")
-        validate_path("my/path/")
+    def test_valid_path_regexs(self):
+        validate_path_re("/my/path")
+        validate_path_re("/my/path/")
+        validate_path_re("my/path/")
+        validate_path_re(r"^/my/(path)?$")
 
 
 class ValidateBooleanTestCase(TestCase):

tox.ini

@@ -21,7 +21,7 @@ deps=
     dj31: Django>=3.1,<3.2
 
 [testenv:lint]
-basepython=python3.6
+basepython=python3.8
 deps=
     black
     flake8