This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the landing page (main view) into a Django class-based view and moves it into its own module. It also adds various unit tests to cover this view.
This is a partial fix to the issue in #44 where non-GET (e.g. POST) requests to this view would raise a 500 error.
This commit adds a dummy
data/header-only.xml
RegML file (which validates against the schema) that can be used for simple testing of this view only. The new unit tests for this view validate that it works with no data or with data loaded.This commit also adds a simple unittest against
eregs_core.urls
to ensure that the URLs module can be imported (to protect against syntax errors which would otherwise not be discovered via the test suite).Additions
Changes
eregs_core.views.main
into a Django class-based view ateregs_core.views.main.MainView
.Testing
tox -e dj18
../manage.py runserver
and navigate to http://localhost:8000.Checklist