Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Adding no rel attributes to links for security fix #69

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Adding no rel attributes to links for security fix #69

merged 1 commit into from
Dec 6, 2017

Conversation

sebworks
Copy link
Contributor

@sebworks sebworks commented Dec 4, 2017 •
edited
Loading

Adding no rel attributes to links for security fix

Testing

  • Run existing unit and acceptance tests.
  • Ensure application links perform as normal.

Review

Preview this PR without the whitespace changes

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

grapesmoker
grapesmoker approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@grapesmoker grapesmoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sebworks sebworks merged commit 2eea279 into master Dec 6, 2017
@sebworks sebworks deleted the fix_for_security_links branch December 6, 2017 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grapesmoker grapesmoker grapesmoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebworks @grapesmoker