This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Streamline dockerfiles #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Use a custom build script instead of messy chained together RUN | ||
| # or multiple RUN statements that add bloat to the image | ||
| # |
There was a problem hiding this comment.
Looks like there's supposed to be a comment here?
| #!/bin/bash | ||
|
|
||
| # Start mongo | ||
| /tmp/entrypoint.sh mongod& |
There was a problem hiding this comment.
I'm curious how Docker handles this, with the mongod processes it put into the background.
- Do
mongodlogs get written to stdout/stderr and get picked up as Docker logs as when running in the foreground? - Does the container stop when the
mongodprocess dies?
Do mongod logs get logged to the console appropriately? I know there can be issues when you put a process into the background.
There was a problem hiding this comment.
Nope, nope, and nope. This approach is prettttty hacky and in fact needs to be replaced (before a merge, actually).
|
Cool. Yeah, this looks better. Merging... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to both dockerfiles herein. Main changes: