Integrate jscs style checking

.jscsrc

@@ -0,0 +1,66 @@
+{
+    "disallowSpacesInNamedFunctionExpression": {
+        "beforeOpeningRoundBrace": true
+    },
+    "disallowSpacesInFunctionExpression": {
+        "beforeOpeningRoundBrace": true
+    },
+    "disallowSpacesInAnonymousFunctionExpression": {
+        "beforeOpeningRoundBrace": true
+    },
+    "disallowSpacesInFunctionDeclaration": {
+        "beforeOpeningRoundBrace": true
+    },
+    "disallowEmptyBlocks": true,
+    "disallowSpacesInsideArrayBrackets": true,
+    "disallowSpacesInsideParentheses": true,
+    "disallowQuotedKeysInObjects": true,
+    "disallowSpaceAfterObjectKeys": true,
+    "disallowSpaceAfterPrefixUnaryOperators": true,
+    "disallowSpaceBeforePostfixUnaryOperators": true,
+    "disallowSpaceBeforeBinaryOperators": [
+        ","
+    ],
+    "disallowMixedSpacesAndTabs": true,
+    "disallowTrailingWhitespace": true,
+    "disallowTrailingComma": true,
+    "disallowYodaConditions": true,
+    "disallowKeywords": [ "with" ],
+    "disallowMultipleLineBreaks": true,
+    "requireSpaceBeforeBlockStatements": true,
+    "requireParenthesesAroundIIFE": true,
+    "requireSpacesInConditionalExpression": true,
+    "requireBlocksOnNewline": 1,
+    "requireCommaBeforeLineBreak": true,
+    "requireSpaceBeforeBinaryOperators": true,
+    "requireSpaceAfterBinaryOperators": true,
+    "requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties",
+    "requireLineFeedAtFileEnd": true,
+    "requireCapitalizedConstructors": true,
+    "requireDotNotation": true,
+    "requireSpacesInForStatement": true,
+    "requireSpaceBetweenArguments": true,
+    "requireCurlyBraces": [
+        "do"
+    ],
+    "requireSpaceAfterKeywords": [
+        "if",
+        "else",
+        "for",
+        "while",
+        "do",
+        "switch",
+        "case",
+        "return",
+        "try",
+        "catch",
+        "typeof"
+    ],
+    "requirePaddingNewLinesBeforeLineComments": {
+        "allExcept": "firstAfterCurly"
+    },
+    "safeContextKeyword": "_this",
+    "validateLineBreaks": "LF",
+    "validateQuoteMarks": "'",
+    "validateIndentation": 4
+}

Gruntfile.js

@@ -42,7 +42,7 @@ module.exports = function (grunt) {
     });
 
     grunt.registerTask('clean_all', [ 'clean:node_modules', 'clean:coverage', 'npm_install' ]);
-    grunt.registerTask('test', ['env:test', 'clean:coverage', 'jshint', 'mocha_istanbul']);
+    grunt.registerTask('test', ['env:test', 'clean:coverage', 'jscs:all', 'jshint', 'mocha_istanbul']);
     grunt.registerTask('coverage', ['test', 'open_coverage']);
     grunt.registerTask('generate-docs', ['apidoc']);
     grunt.registerTask('dist', ['compress:hmda-edit-check-api']);

controllers/getMetroAreasOnRespondentPanel.js

@@ -13,7 +13,7 @@ module.exports = function(router) {
      * @apiParam {String} respondentId Ten-digit number used to identify a HMDA reporting institution
      */
     router.get('/:activityYear/:agencyCode/:respondentId', function(req, res) {
-        MsaBranchesService.getMetroAreasOnRespondentPanel(req.params.activityYear, req.params.agencyCode, 
+        MsaBranchesService.getMetroAreasOnRespondentPanel(req.params.activityYear, req.params.agencyCode,
             req.params.respondentId, function(err, result) {
             if (err) {
                 res.status(500).json(err);

controllers/index.js

@@ -1,18 +1,13 @@
 'use strict';
 
-
 var IndexModel = require('../models/index');
 
-
-module.exports = function (router) {
+module.exports = function(router) {
 
     var model = new IndexModel();
 
-
-    router.get('/', function (req, res) {
-
+    router.get('/', function(req, res) {
         res.send('<code><pre>' + JSON.stringify(model, null, 2) + '</pre></code>');
-
     });
 
 };

controllers/isChildFI.js

@@ -6,7 +6,7 @@ module.exports = function(router) {
 
     /**
      * @api {get} /isChildFI/:activityYear/:agencyCode/:respondentId isChildFI
-     * @apiDescription checks whether or not the respondent has a valid parent organization 
+     * @apiDescription checks whether or not the respondent has a valid parent organization
      * @apiGroup Panel
      * @apiParam {String} activityYear The year for which the HMDA data is being collected
      * @apiParam {String} agencyCode Code to identify the supervisory/regulatory agency of the HMDA reporting institution

controllers/isCraReporter.js

@@ -6,7 +6,7 @@ module.exports = function(router) {
 
     /**
      * @api {get} /isCraReporter/:activityYear/:agencyCode/:respondentId isCraReporter
-     * @apiDescription checks whether or not the respondent is on the list of organizations required to file Community Reinvestment Act (CRA) information 
+     * @apiDescription checks whether or not the respondent is on the list of organizations required to file Community Reinvestment Act (CRA) information
      * @apiGroup CRA Reporters
      * @apiParam {String} activityYear The year for which the HMDA data is being collected
      * @apiParam {String} agencyCode Code to identify the supervisory/regulatory agency of the HMDA reporting institution

controllers/isMetroAreaOnRespondentPanel.js

@@ -11,7 +11,7 @@ module.exports = function(router) {
      * @apiParam {String} activityYear The year for which the HMDA data are being collected
      * @apiParam {String} agencyCode Code to identify the supervisory/regulatory agency of the HMDA reporting institution
      * @apiParam {String} respondentId Ten-digit number used to identify a HMDA reporting institution
-     * @apiParam {String} metroArea 5-digit code for the Metropolitan Statistical Authority/Metropolitan Division 
+     * @apiParam {String} metroArea 5-digit code for the Metropolitan Statistical Authority/Metropolitan Division
      */
     router.get('/:activityYear/:agencyCode/:respondentId/:metroArea', function(req, res) {
         MsaBranchesService.isMetroAreaOnRespondentPanel(req.params.activityYear, req.params.agencyCode, req.params.respondentId, req.params.metroArea, function(err, result) {

controllers/isValidCensusInMSA.js

@@ -20,7 +20,7 @@ module.exports = function(router) {
         censusparams.state_code = req.params.state;
         censusparams.county_code = req.params.county;
         censusparams.tract = req.params.tract;
-        
+
         CensusService.isValidCensusCombination(req.params.activityYear, censusparams, function(err, result) {
             if (err) {
                 res.status(500).json(err);

controllers/isValidCensusTractCombo.js

@@ -11,7 +11,7 @@ module.exports = function(router) {
      * @apiParam {String} activityYear The year for which the HMDA data is being collected
      * @apiParam {String} state 2-digit FIPS code that identifies the state
      * @apiParam {String} county 3-digit FIPS code that identifies the county
-     * @apiParam {String} metroArea 5-digit code to identify the Metropolitan Statistical Authority/Metropolitan Division     
+     * @apiParam {String} metroArea 5-digit code to identify the Metropolitan Statistical Authority/Metropolitan Division
      * @apiParam {String} tract 6-digit census tract number
      */
     router.get('/:activityYear/:state/:county/:metroArea/:tract', function(req, res) {

controllers/isValidLar/all.js

@@ -19,4 +19,4 @@ module.exports = function(router) {
             }
         });
     });
-};
+};

controllers/isValidLar/type.js

@@ -9,7 +9,7 @@ module.exports = function(router) {
      * @apiDescription runs all applicable checks of the supplied type against the supplied lar.
      * @apiGroup Engine
      * @apiParam {String} activityYear  The year for which the HMDA data is being collected
-     * @apiParam {String} editType      The type of edits to run 
+     * @apiParam {String} editType      The type of edits to run
      */
     router.post('/:activityYear/:editType', function(req, res) {
         EngineService.runLarType(req.params.activityYear, req.params.editType, req.body, function(err, result) {
@@ -20,4 +20,4 @@ module.exports = function(router) {
             }
         });
     });
-};
+};

controllers/isValidStateCounty.js

@@ -13,7 +13,6 @@ module.exports = function(router) {
      * @apiParam {String} county 3-digit FIPS code that identifies the county
      */
     router.get('/:activityYear/:state/:county', function(req, res) {
-
         CensusService.isValidStateCounty(req.params.activityYear, req.params.state, req.params.county, function(err, result) {
             if (err) {
                 res.status(500).json(err);

controllers/isValidTimestamp.js

@@ -12,13 +12,13 @@ module.exports = function(router) {
      * @apiParam {String} agencyCode Code to identify the supervisory/regulatory agency of the HMDA reporting institution
      * @apiParam {String} respondentId Ten-digit number used to identify a HMDA reporting institution
      */
-     router.get('/:activityYear/:agencyCode/:respondentID/:timestamp', function(req, res) {
-         TransmittalService.isValidTimestamp(req.params.activityYear, req.params.agencyCode, req.params.respondentID, req.params.timestamp, function(err, result) {
-             if (err) {
-                 res.status(500).json(err);
-             } else {
-                 res.json(result);
-             }
-         });
-     });
+    router.get('/:activityYear/:agencyCode/:respondentID/:timestamp', function(req, res) {
+        TransmittalService.isValidTimestamp(req.params.activityYear, req.params.agencyCode, req.params.respondentID, req.params.timestamp, function(err, result) {
+            if (err) {
+                res.status(500).json(err);
+            } else {
+                res.json(result);
+            }
+        });
+    });
 };

lib/404.js

@@ -1,11 +1,10 @@
 'use strict';
 
-
-module.exports = function (template) {
+module.exports = function(template) {
 
     return function fileNotFound(req, res, next) {
         var globalError = { result: false };
         res.status(200).send(globalError);
     };
 
-};
+};

lib/database.js

@@ -3,7 +3,7 @@
 var mongoose = require('mongoose');
 
 var db = {
-    configure: function (conf) {
+    configure: function(conf) {
         var uri = 'mongodb://' + conf.host + ':' + conf.port + '/' + (conf.database ? conf.database : 'hmda');
         var opts = {};
         if (conf.username) {
@@ -21,5 +21,4 @@ var db = {
     }
 };
 
-
-module.exports = db;
+module.exports = db;

lib/engine/engineCustomDataLookupConditions.js

@@ -41,9 +41,9 @@ var EngineCustomDataLookupConditions = (function() {
 
         this.isValidMsaMdStateAndCountyCombo = function(metroArea, fipsState, fipsCounty) {
             var censusParams = {
-                'msa_code': metroArea,
-                'state_code': fipsState,
-                'county_code': fipsCounty
+                msa_code: metroArea,
+                state_code: fipsState,
+                county_code: fipsCounty
             };
             return promisifyService(CensusService.isValidCensusCombination, [this.getRuleYear(), censusParams])
             .then(function(response) {
@@ -78,4 +78,4 @@ var EngineCustomDataLookupConditions = (function() {
     };
 })();
 
-module.exports = EngineCustomDataLookupConditions;
+module.exports = EngineCustomDataLookupConditions;

lib/options.js

@@ -5,7 +5,7 @@ var db = require('./database');
 module.exports = function options(app) {
 
     return {
-        onconfig: function (config, next) {
+        onconfig: function(config, next) {
             db.configure(config.get('mongoConfig'));
             next(null, config);
         }

models/census.js

@@ -3,15 +3,15 @@
 var mongoose = require('mongoose');
 
 var censusSchema = mongoose.Schema({
-    'activity_year': String,
-    'msa_code': String,
-    'msa_name': String,
-    'state_code': String,
-    'county_code': String,
-    'small_county': String,
-    'tract': String
+    activity_year: String,
+    msa_code: String,
+    msa_name: String,
+    state_code: String,
+    county_code: String,
+    small_county: String,
+    tract: String
 });
-censusSchema.index({'activity_year': 1, 'msa_code': 1, 'state_code': 1, 'county_code': 1, 'tract': 1});
-censusSchema.index({'activity_year': 1, 'state_code': 1, 'county_code': 1, 'tract': 1});
-censusSchema.index({'activity_year': 1, 'state_code': 1, 'county_code': 1, 'small_county': 1});
+censusSchema.index({activity_year: 1, msa_code: 1, state_code: 1, county_code: 1, tract: 1});
+censusSchema.index({activity_year: 1, state_code: 1, county_code: 1, tract: 1});
+censusSchema.index({activity_year: 1, state_code: 1, county_code: 1, small_county: 1});
 module.exports = mongoose.model('Census', censusSchema, 'census');

models/craReporters.js

@@ -3,10 +3,10 @@
 var mongoose = require('mongoose');
 
 var craReportersSchema = mongoose.Schema({
-    'activity_year': String,
-    'respondent_id': String,
-    'agency_code': String,
-    'respondent_name': String
+    activity_year: String,
+    respondent_id: String,
+    agency_code: String,
+    respondent_name: String
 });
-craReportersSchema.index({'activity_year': 1, 'respondent_id': 1, 'agency_code': 1});
+craReportersSchema.index({activity_year: 1, respondent_id: 1, agency_code: 1});
 module.exports = mongoose.model('CraReporters', craReportersSchema, 'cra_reporters');

models/index.js

@@ -1,6 +1,5 @@
 'use strict';
 
-
 module.exports = function IndexModel() {
     return {
         name: 'index'

models/lar.js

@@ -3,20 +3,20 @@
 var mongoose = require('mongoose');
 
 var larSchema = mongoose.Schema({
-    'activity_year': String,
-    'agency_code': String,
-    'respondent_id': String,
-    'totalLoans' : String,
-    'totalHomePurchaseLoans' : String,
-    'soldHomePurchaseLoans' : String,
-    'totalRefinanceLoans' : String,
-    'soldRefinanceLoans' : String,
-    'totalQ70' : String, 
-    'compareQ70' : String, 
-    'totalQ71' : String, 
-    'compareQ71' : String,
-    'totalQ72' : String, 
-    'compareQ72' : String
+    activity_year: String,
+    agency_code: String,
+    respondent_id: String,
+    totalLoans: String,
+    totalHomePurchaseLoans: String,
+    soldHomePurchaseLoans: String,
+    totalRefinanceLoans: String,
+    soldRefinanceLoans: String,
+    totalQ70: String,
+    compareQ70: String,
+    totalQ71: String,
+    compareQ71: String,
+    totalQ72: String,
+    compareQ72: String
 });
-larSchema.index({'activity_year': 1, 'respondent_id': 1, 'agency_code': 1});
+larSchema.index({activity_year: 1, respondent_id: 1, agency_code: 1});
 module.exports = mongoose.model('Lar', larSchema, 'lar');

models/msaBranches.js

@@ -3,11 +3,11 @@
 var mongoose = require('mongoose');
 
 var msaBranchesSchema = mongoose.Schema({
-    'activity_year': String,
-    'respondent_id': String,
-    'respondent_name': String,
-    'msa': [String],
-    'agency_code': String
+    activity_year: String,
+    respondent_id: String,
+    respondent_name: String,
+    msa: [String],
+    agency_code: String
 });
-msaBranchesSchema.index({'activity_year': 1, 'respondent_id': 1, 'agency_code': 1, 'msa': 1});
+msaBranchesSchema.index({activity_year: 1, respondent_id: 1, agency_code: 1, msa: 1});
 module.exports = mongoose.model('MsaBranches', msaBranchesSchema, 'msa_branches');

models/panel.js

@@ -3,14 +3,14 @@
 var mongoose = require('mongoose');
 
 var panelSchema = mongoose.Schema({
-    'activity_year': String,
-    'respondent_id': String,
-    'agency_code': String,
-    'respondent_name': String,
-    'parent_name': String,
-    'parent_city': String,
-    'parent_state': String,
-    'other_lender_code': String
+    activity_year: String,
+    respondent_id: String,
+    agency_code: String,
+    respondent_name: String,
+    parent_name: String,
+    parent_city: String,
+    parent_state: String,
+    other_lender_code: String
 });
-panelSchema.index({'activity_year': 1, 'respondent_id': 1, 'agency_code': 1, 'other_lender_code': 1, 'parent_name': 1});
+panelSchema.index({activity_year: 1, respondent_id: 1, agency_code: 1, other_lender_code: 1, parent_name: 1});
 module.exports = mongoose.model('Panel', panelSchema, 'panel');