Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keycloak] Use Proof Key for Code Exchange (PKCE) #1622

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[Keycloak] Use Proof Key for Code Exchange (PKCE) #1622

merged 2 commits into from
Oct 31, 2022

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Oct 20, 2022 •
edited
Loading

Closes #1621

This is tested in DEV and looks good. I don't want it merged yet, in case we need to do any deployments to other environments where PKCE is not yet enabled. Hence leaving in as Draft for now.

@meissadia meissadia changed the title [Cypress] Login via UI [Keycloak] Use Proof Key for Code Exchange (PKCE) Oct 20, 2022
@meissadia meissadia marked this pull request as ready for review October 31, 2022 18:08
Michaeldremy
Michaeldremy approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Michaeldremy Michaeldremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meissadia meissadia merged commit 9b46ba8 into master Oct 31, 2022
@meissadia meissadia deleted the 1621-pkce-keycloak-upgrade branch October 31, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgudel kgudel kgudel approved these changes

@Michaeldremy Michaeldremy Michaeldremy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Keycloak] PKCE
3 participants
@meissadia @kgudel @Michaeldremy