-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Any particular reason why the tests for |
var EngineCustomConditions = (function() { | ||
return function() { | ||
|
||
/* hmda-syntactical */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do comments like these actually add anything anymore? When everything was in single file they did help delineate between different areas, but now that you've modularized the code it seems like they should be replaced by jsdoc comments on each function. If so, that might be part of the system documentation task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are just grouping/section type comments, so there still is value, even in the smaller components. Additional jsdoc comments would help, especially documentation tying each function to it's actual edit.
@poorgeek There ya go, tests broken out for the mixins.. |
Cool. Looks good to me! |
Refactor the engine to make use of mixins. Refactor out globals as well and make use of getter/setters.