This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Refactor progress, so it just works against the rules as a whole #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorgeek
added a commit
that referenced
this pull request
Apr 10, 2015
Refactor progress, so it just works against the rules as a whole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the rules are CPU bound, events emitted while inside the rule processing (emitted for each LAR) don't get emitted efficiently. Switch the events so that the percentage is based on all the rules being run during a certain stage in the process rather than all the rules + all the lars. This means we don't have to do a magic number calculation for the macros either.
Because I've yanked so much code in this refactor, coverage numbers will go down a bit.