Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move featured challenge banner into main content column #104

Merged
merged 2 commits into from Dec 11, 2019

Conversation

Scotchester
Copy link
Contributor

@niqjohnson Does this roughly resemble the changes you made in your local setup?

Copy link
Member

@niqjohnson niqjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments wondering about scoping the challenge banner CSS to the header, but otherwise that matches the changes I made locally.

idea/static/idea/css/idea.css Show resolved Hide resolved
idea/static/idea/css/idea.css Show resolved Hide resolved
@Scotchester
Copy link
Contributor Author

The Travis error can be ignored. It's failing to download Python 2.6, presumably because it's been deprecated. No matter, these changes don't impact Python.

@Scotchester Scotchester merged commit 3aa60cd into master Dec 11, 2019
@Scotchester Scotchester deleted the move-featured-challenge branch December 11, 2019 16:53
Scotchester pushed a commit that referenced this pull request Jun 12, 2020
Move featured challenge banner into main content column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants