Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new county changes #386

Merged
merged 12 commits into from Jan 4, 2018
Merged

Add new county changes #386

merged 12 commits into from Jan 4, 2018

Conversation

amymok
Copy link
Contributor

@amymok amymok commented Dec 12, 2017 •
edited

Additions

  • Added new data county changes
  • Added Model changes due to the new data
  • Added code to load the missing tail end data for branch locations

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6ec8e15 on amymok:HMDA-2016 into ** on cfpb:master**.

@amymok amymok changed the title [WIP] Add new county changes Add new county changes Jan 3, 2018
JeffreyMFarley
JeffreyMFarley approved these changes Jan 3, 2018
View reviewed changes
Copy link

@JeffreyMFarley JeffreyMFarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of migrations here

.travis.yml
postgresql: 9.3
apt:
packages:
- postgresql-9.3-postgis-2.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good trick to know. Thanks!

mapusaurus/respondents/management/commands/load_branch_locations.py Outdated
street = branch_location_line[7].strip().upper() if branch_location_line[7] != '0' else '',
city = branch_location_line[8].strip().upper(),
state = branch_location_line[10].strip().upper(),
zipcode = branch_location_line[11].strip(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.strip().upper() can be moved to a normalize() function. This will help if further processing is necessary

@mehtadev17
Copy link
Contributor

Looks good! 👍

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6a152a7 on amymok:HMDA-2016 into ** on cfpb:master**.

@amymok
Copy link
Contributor Author

amymok commented Jan 3, 2018

Thanks @mehtadev17!

@sephcoster sephcoster merged commit b3b7ccc into cfpb:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sephcoster sephcoster sephcoster approved these changes

@JeffreyMFarley JeffreyMFarley JeffreyMFarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amymok @coveralls @mehtadev17 @sephcoster @JeffreyMFarley