Move dj-database-url requirement to base #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only affects this repo, but will keep Jenkins jobs from hitting import failures. The Jenkins jobs install base requirements and then issue manage.py commands, but the repo's manage.py file uses settings_for_testing.py. Since the requirements files only affect this repo, it's most efficient to move the db requirment into base.txt and leave the jenkins jobs alone.
richaagarwal
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects this repo, but will keep Jenkins jobs from
hitting import failures.
The Jenkins jobs install base requirements and then issue manage.py
commands, but the repo's manage.py file uses settings_for_testing.py.
Since the requirements files only affect this repo, it's most efficient
to move the db requirement into base.txt and leave the jenkins jobs
alone.