Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing fees data #127

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Handle missing fees data #127

merged 3 commits into from
Apr 20, 2018

Conversation

virginiacc
Copy link
Contributor

Handle temporary absence of fees data by skipping fees data load when fees file is not found.

@virginiacc virginiacc requested a review from chosak April 19, 2018 21:31
@coveralls
Copy link

coveralls commented Apr 19, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 99.794% when pulling 0fe0f6e on virginiacc:missing-fees-data into bd383a3 on cfpb:master.

chosak
chosak approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; added one minor comment.

Would you mind adding a comment in the code next to the new logic, indicating why 'fee' is being treated specially? Something to explain that we're allowing for temporary absence of the fee data.

ratechecker/dataset.py Outdated
if key == 'fee':
continue
raise
except Exception:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second except clause isn't needed; any other exception type that isn't caught by the except KeyError will bubble up the stack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chosak Updated in 0fe0f6e

@virginiacc
Copy link
Contributor Author

@chosak Thanks for reviewing! I made the suggested change & added a comment about the fees exception in 0fe0f6e.

@virginiacc virginiacc merged commit fffe6d6 into cfpb:master Apr 20, 2018
@virginiacc virginiacc deleted the missing-fees-data branch April 20, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chosak chosak chosak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@virginiacc @coveralls @chosak