Allow Flexible Library Versions #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
approved these changes
Sep 20, 2018
|
|
||
| You can then preview your changes locally by running `mkdocs serve` and then reviewing <http://127.0.0.1:8000/> | ||
|
|
||
| When your changes are ready, you can submit them as a normal pull request. After that, you can use this command to publish them: |
There was a problem hiding this comment.
Thanks for doing this. I noticed that the current live docs are out of date. After we merge this PR, let's run the command to refresh the GH branch.
There was a problem hiding this comment.
Good call. Will do.
README.md
Outdated
|
|
||
| ## API Docs | ||
|
|
||
| [Documentation](https://cfpb.github.io/owning-a-home-api/) for this repository is rendered via GitHub pages and [Swagger](https://swagger.io/docs/). They can be edited in the `docs/` directory, but to view or deploy them, you'll need to install the dependencies listed in the `docs_extras` section of `setup.py`: |
There was a problem hiding this comment.
Swagger isn't used by the docs here; was this copied from ccdb5-api?
There was a problem hiding this comment.
Oops. Yes, I did copy-paste this text. Fixed now.
For most libraries, allow any revision within a major version. Ensure that the set of allowed versions contains the actual version that cfgov-refresh is currently on, so when we import and install this repo in cfgov, it doesn't cause version conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.