Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions and Replace Travis Badge with Github Action Badge #3

Merged
merged 13 commits into from
Sep 14, 2020

Conversation

cwdavies
Copy link
Contributor

@cwdavies cwdavies commented Sep 1, 2020

This adds GitHub Action workflows for CI and release
Lint errors are also fixed in the PR due to isort 5.0:

  • recursive – Prior to version 5.0.0, isort wouldn't automatically traverse directories. The --recursive option was necessary to tell it to do so. In 5.0.0 directories are automatically traversed for all Python files, and as such this option is no longer necessary and should simply be removed.
  • not_skip – In an earlier version isort had a default skip of init.py. To get around that many projects wanted a way to not skip init.py or any other files that were automatically skipped in the future by isort. isort no longer has any default skips, so if the value here is init.py you can simply remove the setting.

https://timothycrosley.github.io/isort/docs/upgrade_guides/5.0.0/

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Scotchester
Copy link
Contributor

This is missing a new GitHub Actions job to run coveralls.

@cwdavies
Copy link
Contributor Author

cwdavies commented Sep 14, 2020

This is missing a new GitHub Actions job to run coveralls.

Thanks for this feedback. I added a job to run coveralls to GitHub Actions.

@cwdavies cwdavies merged commit 5ecec3c into main Sep 14, 2020
@cwdavies cwdavies deleted the github-actions branch September 14, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants