[Resolve Errors] [Review Warnings] Tables - full borders will only show when overflowing (horizontal scrolling active)

[shindigira]

closes #547

Note: Requires cfpb/design-system-react#358 to be merged in first

Changes

• enhancement-style(tables): full borders will only show for overflowing
• chore(tables): removed the need for showTableBorders

How to test this PR

1. yarn install to get the latest DSR update with the table ref change
2. use all-errors-warnings-no-syntax-errors.csv or any register with multifield errors that causes overflowing/horizontal scrolling
3. Verify that tables without overflowing don't have full borders, tables that do have overflowing/horizontal scrolling have full borders

Screenshot

[billhimmelsbach]

Looking good! One quick perf question.

[billhimmelsbach]

Sounds good! Looking forward to the follow-up PR!

[natalia-fitzgerald]

@shindigira
In the screenshot the bottom border is missing. It should be there if the other borders are present.

I noticed that on AWS sometimes the bottom border renders and other times it does not.

Bottom border renders

Bottom border does not render