Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wagtail-specific app and remove django-flags duplication #29

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

willbarton
Copy link
Member

@willbarton willbarton commented Jun 22, 2018

This PR corresponds to cfpb/django-flags#1 and closes #28.

This is the wagtail-flags side of splitting this library up into a pure-Django flags library and one that provides Wagtail support on top of that.

This is a breaking change, sort of. This PR does two major things:

Any Django projects that were previously using wagtail-flags will now need to make sure they include the following apps in INSTALLED_APPS:

INSTALLED_APPS = (
    ...
    'flags',
    'wagtailflags',
    ...
)

Because Wagtail-Flags requires Django-Flags, only including flags will mean that all previous functionality continues as expected (except for Wagtail Site-based flag conditions), but the Wagtail admin UI will be gone.

That is why this will be version 3.0.0.

This PR won't pass CI until cfpb/django-flags#1 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split into Wagtail specific and Django Generic
1 participant