Hide flag name in condition edit form #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `WAGTAILFLAGS_ADMIN_BIG_LIST` flag was to allow us to test whether we wanted to use the new(ish) Wagtail Flags UI, and we did. This change removes all the old one-big-list-of-flags-and-conditions
willbarton
requested review from
higs4281,
Scotchester,
schbetsy and
cwdavies
cwdavies
reviewed
Feb 25, 2020
There was a problem hiding this comment.
The changes to hide flag name from the form has been completed and verified.
It might be worth fixing the lint errors in views.py and test_views.py for:
F401 'django.shortcuts.resolve_url' imported but unused
F401 'flags.state.flag_enabled' imported but unused
F401 'django.test.override_settings' imported but unused
|
I will miss the big list, but apparently I'm the only one, so I won't put up too much of a stink 😛 |
This change hides the flag name field from condition creation and edit forms. The field was not editable by users, because the flag name is always provided. The field had been rendering as blank, despite having the value filled in. This change moves it to a hidden field.
willbarton
force-pushed
the
hide-flag-name
branch
from
db513d5
to
da9a021
Compare
Indeed! I've done so. |
cwdavies
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
FlagStateFormto hide the flag name field. The flag name field was already read-only, and was appearing in the Wagtail admin as blank. The field is now hidden.Before:
After:
This PR also removes the deprecated
WAGTAILFLAGS_ADMIN_BIG_LISTflag for the big-list-of-all-flags-and-conditions admin UI.