Inherit the FlagStateForm from Django Flags #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will use the FlagStateForm from Django-Flags as the superclass for the Wagtail-Flags FlagStateForm. This way, Wagtail-Flags will use the Django-Flags condition validators introduced in Django-Flags 5.0.
alexm118
approved these changes
Aug 19, 2020
willbarton
added a commit
that referenced
this pull request
Aug 19, 2020
These tests are failing validation after #54. I'm not sure why they didn't fail in that PR itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will use the
FlagStateFormfrom Django-Flags as the superclass for the Wagtail-Flags'FlagStateForm.This enables Wagtail-Flags to use the Django-Flags condition validators introduced in Django-Flags 5.0.
In Wagtail-Flags, this will look like this:
When a value is entered that a condition's validator does not accept.