Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wagtail 2.16 and Django 4.0 #56

Merged
merged 4 commits into from
May 13, 2022
Merged

Conversation

chosak
Copy link
Member

@chosak chosak commented May 11, 2022

This commit adds support for Wagtail version 3.02.16 and Django version 4.0, while still maintaining support for all previous versions. This supersedes #54.

To comply with the Django 3.2 recommendation around use of BigAutoField for model primary keys, a migration has been added that alters the type of the PageBlock primary key to this type.

Automatic testing of Wagtail 2.16 has been dropped in favor of testing against Wagtail 3.0. Note that this PR currently hardcodes a pre-release version of Wagtail (3.0rc3) for testing purposes. This should be updated to a valid release range once 3.0 is released next week. Edited: I've retarted this PR to Wagtail 2.16 per #54 (comment).

This commit adds support for Wagtail version 3.0 and Django version
4.0, while still maintaining support for all previous versions.

To comply the Django 3.2 recommendation around use of BigAutoField for
model primary keys, a migration has been added that alters the type
of the PageBlock primary key to this type.

Automatic testing of Wagtail 2.16 has been dropped in favor of testing
against Wagtail 3.0.
@chosak chosak mentioned this pull request May 11, 2022
@chosak chosak changed the title Add support for Wagtail 3.0 and Django 4.0 Add support for Wagtail 2.16 and Django 4.0 May 12, 2022
@chosak chosak merged commit b728e86 into main May 13, 2022
@chosak chosak deleted the feature/wagtail3-django4 branch May 13, 2022 15:39
@rgs258
Copy link

rgs258 commented May 16, 2022

ty @chosak

@chosak
Copy link
Member Author

chosak commented May 18, 2022

@rgs258 @FlipperPA this support should now be out in wagtail-inventory release 1.5, now available at a PyPI near you.

@FlipperPA
Copy link

@chosak No matter what I say behind your back, on here, I will say you are a scholar and a cherub! 💯 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants