Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Django requirement from this application #17

Merged
merged 4 commits into from
May 11, 2020

Conversation

cwdavies
Copy link
Contributor

@cwdavies cwdavies commented May 4, 2020

We should probably only pin Wagtail in this application, and support
the version range for Django that our Wagtail version specifies.

We should probably only pin Wagtail in this application, and support
the version range for Django that our Wagtail version specifies.
@coveralls
Copy link

coveralls commented May 4, 2020

Pull Request Test Coverage Report for Build 845

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 799: 0.0%
Covered Lines: 202
Relevant Lines: 202

💛 - Coveralls

@cwdavies
Copy link
Contributor Author

cwdavies commented May 4, 2020

Wagtail 2.9 was released today, Do we want to start thinking about heading right to that instead of 2.8?

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too broad a removal of Django. We still need to test against Django 1.11 and 2.2 (we could drop testing against 2.0).

We just do not need to specify a required version in setup.py for pip to resolve dependencies. For that we can take whatever the version of Wagtail we're using provides.

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too broad a removal of Django. We still need to test against Django 1.11 and 2.2 (we could drop testing against 2.0).

We just do not need to specify a required version in setup.py for pip to resolve dependencies. For that we can take whatever the version of Wagtail we're using provides.

tox.ini Outdated Show resolved Hide resolved
@cwdavies cwdavies requested a review from willbarton May 8, 2020 16:19
@cwdavies cwdavies merged commit 791c254 into master May 11, 2020
@cwdavies cwdavies deleted the remove-django-requirement branch May 11, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants