Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyGen and KeyValidate updates #26

Merged
merged 3 commits into from
Sep 8, 2020
Merged

KeyGen and KeyValidate updates #26

merged 3 commits into from
Sep 8, 2020

Conversation

kwantam
Copy link
Collaborator

@kwantam kwantam commented Sep 7, 2020

This PR closes #25 by making clear that SK == 0 is never allowed. In particular:

  • it fixes KeyGen to never return SK == 0.
  • it also fixes a slight abuse of HKDF in prior versions, namely, the salt parameter is supposed to be a (close to) uniformly random string for the HKDF security analysis to hold. Now we always pass salt through H at least once, so we meet this requirement.
  • it updates KeyValidate to return INVALID for identity pubkeys
  • it says explicitly in the KeyGen section that other methods for keygen are OK as long as they meet the security requirements. Note that this was explicitly stated elsewhere in the document in prior versions; I've removed these redundant statements.
  • it updates Security Considerations to give the rationale for disallowing SK == 0.

@hoeteck hoeteck merged commit 03a1d2d into cfrg:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyGen, weak keys, and interop
4 participants