Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendation on how to hash to ristretto255 #294

Merged
merged 4 commits into from Aug 23, 2020

Conversation

kwantam
Copy link
Collaborator

@kwantam kwantam commented Aug 9, 2020

This PR adds a short appendix that defines a hash_to_curve--like function for ristretto255.

Closes #291

@kwantam
Copy link
Collaborator Author

kwantam commented Aug 9, 2020

Per @grittygrease's statement in #291, I think once we're happy with this text we should push an updated draft and request feedback on the cfrg list about this.

Copy link
Collaborator

@chris-wood chris-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content LGTM — thanks!

@kwantam
Copy link
Collaborator Author

kwantam commented Aug 9, 2020

Thanks @chris-wood! I pushed a very small edit that refs to the domain separation recommendations from the appendix, but now I'll stop messing around with it :)

@chris-wood
Copy link
Collaborator

The edits still look good :-) I suggest we take this to the list now. (@armfazh is out this week and won't be able to review for a while.)

@kwantam
Copy link
Collaborator Author

kwantam commented Aug 11, 2020

What's the best way to do this? Ref the list to this PR?

@chris-wood
Copy link
Collaborator

What's the best way to do this? Ref the list to this PR?

Yep, that’ll do!

@chris-wood
Copy link
Collaborator

@kwantam shall we merge this? There's been no pushback, and it seems like the best option (in my opinion).

@jedisct1
Copy link
Contributor

Looks good to me.

@kwantam
Copy link
Collaborator Author

kwantam commented Aug 23, 2020

Feedback has been more positive than negative, so I think it passes the bar for inclusion 👍

There is a small remaining question that we can decide not to address now: if the ristretto draft adds decaf for edwards448 we might also want to give a recommendation for that. Happy to merge this and update later if that becomes necessary.

@chris-wood
Copy link
Collaborator

chris-wood commented Aug 23, 2020

There is a small remaining question that we can decide not to address now: if the ristretto draft adds decaf for edwards448 we might also want to give a recommendation for that. Happy to merge this and update later if that becomes necessary.

I heard that Mike might join the ristretto255 draft and add decaf448 in the process. When that happens, we can that method in a followup PR.

@chris-wood chris-wood merged commit 4fc19e5 into cfrg:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggest way of composing expand_message with ristretto's FROM_UNIFORM_BYTES?
3 participants