Some corrections to the text #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-wood
approved these changes
Jan 8, 2024
draft-irtf-cfrg-opaque.md
Outdated
| clients to safely store and retrieve arbitrary application data on servers | ||
| using only their password. | ||
| using only their passwords. |
There was a problem hiding this comment.
Suggested change
| using only their passwords. | |
| using only their password. |
There was a problem hiding this comment.
I'm not native in English so it's very probable that my suggestion comes from another language.
But does putting the singular to password not mean something like "the one password that all the clients have" instead of "the password of each client"?
There was a problem hiding this comment.
I think it is best left singular, agree with Chris's suggestion here
Co-authored-by: Christopher Wood <caw@heapingbits.net>
Co-authored-by: Christopher Wood <caw@heapingbits.net>
kevinlewi
requested changes
Mar 3, 2024
draft-irtf-cfrg-opaque.md
Outdated
| @@ -1923,7 +1923,7 @@ protocols such as TLS. | |||
| The specification as written here differs from the original cryptographic design in {{JKX18}} | |||
| and the corresponding CFRG document {{I-D.krawczyk-cfrg-opaque-03}}, both of which were used | |||
| as input to the CFRG PAKE competition. This section describes these differences, including | |||
| their motivation and explanation as to why they preserve the provable security of OPAQUE based | |||
| their motivation and explanation as to why they preserve the provable security of OPAQUE-based | |||
There was a problem hiding this comment.
this change should be reverted
| @@ -2233,7 +2233,7 @@ message for an unregistered client if these client enumeration attacks can | |||
| be mitigated through other application-specific means or are otherwise not | |||
| applicable for their threat model. | |||
|
|
|||
| OPAQUE does not prevent against this type of attack during the registration flow. | |||
| OPAQUE does not prevent this type of attack during the registration flow. | |||
There was a problem hiding this comment.
I think a better change would be "protect against"
draft-irtf-cfrg-opaque.md
Outdated
| clients to safely store and retrieve arbitrary application data on servers | ||
| using only their password. | ||
| using only their passwords. |
There was a problem hiding this comment.
I think it is best left singular, agree with Chris's suggestion here
draft-irtf-cfrg-opaque.md
Outdated
| @@ -329,7 +329,7 @@ as a "compiler" for transforming any suitable AKE protocol into a secure | |||
| aPAKE protocol. (See {{security-considerations}} for requirements of the | |||
| OPRF and AKE protocols.) This document specifies one OPAQUE instantiation | |||
| based on {{TripleDH}}. Other instantiations are possible, as discussed in | |||
| {{alternate-akes}}, but their details are out of scope for this document. | |||
| {{alternate-akes}}, but their details are out of the scope of this document. | |||
There was a problem hiding this comment.
I would revert this change
kevinlewi
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was rereading the draft, I saw a couple of mistakes and missing spaces. So I ran the text through a corrector that found some other suggestions.