poc: Plumb coins to measurement_to_input_shares()
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
changed the title
measurmeent_to_input_shares()measurement_to_input_shares()
cjpatton
force-pushed
the
cjpatton/vdaf-05/7/test-vec-rand
branch
2 times, most recently
from
539febe
to
2d6f1af
Compare
divergentdave
approved these changes
Mar 2, 2023
To improve test vector quality, we will need to be able to specify a particular sequence of random coins used by the Client to split its measurement. Add a paramter to `Daf.measurmeent_to_input_shares()` and `Vdaf.measurmeent_to_input_shares()` for the random coins. In addition, have the object specify the size of the byte string it expects. Similarly for `Idpf`. Accordingly, remove all calls to `gen_rand()` from `Prio3`, `Poplar1`, and `IdpfPoplar` and instead use the coins passed to the API.
cjpatton
force-pushed
the
cjpatton/vdaf-05/7/test-vec-rand
branch
from
2d6f1af
to
e49104a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #184 (merge that first).
Partially addresses #173.
To improve test vector quality, we will need to be able to specify a particular sequence of random coins used by the Client to split its measurement.
Add a paramter to
Daf.measurmeent_to_input_shares()andVdaf.measurmeent_to_input_shares()for the random coins. In addition, have the object specify the size of the byte string it expects. Similarly forIdpf.Accordingly, remove all calls to
gen_rand()fromPrio3,Poplar1, andIdpfPoplarand instead use the coins passed to the API.