Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to test vector generation #326

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

junyechen1996
Copy link
Contributor

Add an environmental variable TEST_VECTOR to control test vector generation, and an optional environmental variable TEST_VECTOR_PATH to specify a custom path where test vectors are generated. Add a new target in Makefile to generate all test vectors in VDAF spec.

@cjpatton cjpatton self-requested a review January 22, 2024 14:39
Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! One minor suggestion.

poc/Makefile Outdated Show resolved Hide resolved
poc/README.md Show resolved Hide resolved
Copy link
Collaborator

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and then I'll merge.

Add an environmental variable TEST_VECTOR to control test vector
generation, and an optional environmental variable TEST_VECTOR_PATH
to specify a custom path where test vectors are generated.
@junyechen1996
Copy link
Contributor Author

Squashed. Should be good to merge after CI.

@cjpatton cjpatton merged commit b87c2d6 into cfrg:main Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants