Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update onReceiveProgress references in docs #1732

Merged
merged 2 commits into from
Mar 12, 2023
Merged

fix: update onReceiveProgress references in docs #1732

merged 2 commits into from
Mar 12, 2023
+10 −10

Conversation

cgutierr-zgz
Copy link
Contributor

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Small update on the docs making reference to onProgress instead of onReceiveProgress

@cgutierr-zgz
fix: update onReceiveProgress references in docs
fd420fc 
Signed-off-by: Carlos Gutiérrez Moreno <carlosgutimo.3d@gmail.com>
@cgutierr-zgz cgutierr-zgz requested a review from a team as a code owner March 11, 2023 15:19
ueman
ueman reviewed Mar 11, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

dio/lib/src/dio.dart Outdated Show resolved Hide resolved
ueman
ueman approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! It looks good to me 👍

@ueman ueman merged commit 70cdbf9 into cfug:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgutierr-zgz @ueman