Abort HttpRequests when CancelToken is cancelled #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer close the HttpClient but instead abort individual requests. This has the added benefit of less HttpClients being constructed. If `CancelToken.cancel` is called before the request has started, cancel the whole operation.
kuhnroyal
added
p: dio
AlexV525
reviewed
May 15, 2023
AlexV525
approved these changes
May 15, 2023
AlexV525
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer close the
HttpClientbut instead abort individual requests. This has the added benefit of fewerHttpClients being constructed. IfCancelToken.cancelis called before the request has started, cancel the whole operation.The
HttpClientRequest.abortmethod was added in Dart 2.10.New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)
Fixes #1811.