Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements #1875

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Test improvements #1875

merged 2 commits into from
Jun 21, 2023

Conversation

kuhnroyal
Copy link
Member

@kuhnroyal kuhnroyal commented Jun 17, 2023 •
edited

  • restore base64 comparison in upload tests - httpbun has base64 data now implemented
  • add tests for async SocketException being thrown in IO adapter

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal added the p: dio Targeting `dio` package label Jun 17, 2023
@kuhnroyal kuhnroyal self-assigned this Jun 17, 2023
@kuhnroyal kuhnroyal requested a review from a team as a code owner June 17, 2023 14:01
AlexV525
AlexV525 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhnroyal kuhnroyal mentioned this pull request Jun 20, 2023
Closed
@AlexV525 AlexV525 merged commit 7cfadc4 into cfug:main Jun 21, 2023
27 checks passed
@kuhnroyal kuhnroyal deleted the tests branch August 8, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees

@kuhnroyal kuhnroyal

Labels
p: dio Targeting `dio` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuhnroyal @AlexV525