Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the HTTP2 Adapter for Requests with Payload #760

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

hongyiweiwu
Copy link
Contributor

@hongyiweiwu hongyiweiwu commented Apr 29, 2020

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

This merge request fixes / refers to the following issues:

The current HTTP2 adapter doesn't work when the request contains a payload, because it only starts sending the payload after the response header from the server has been received. However, the server won't start sending the response header until the entire payload is received from the client. Hence the connection is in a deadlock until either the client or the server times out.

This pull request fixes this issue by transmitting the entire payload body before starting to listen for responses.

...

@hongyiweiwu hongyiweiwu changed the title Payload body is now sent before any responses are received. Fixes the HTTP2 Adapter for Requests with Payload Apr 29, 2020
This was referenced Apr 29, 2020
@posativ
Copy link

posativ commented Apr 30, 2020

It will also fix #762 (endStream is no longer set to false).

@krokyze
Copy link

krokyze commented May 29, 2020

@wendux could you please merge this? Thanks.

@ylogx
Copy link

ylogx commented Jun 6, 2020

I've verified that the patch works for POST calls (which aren't working in the current release). This should be released on pub.dev soon.

@byteslaves
Copy link

This is available, thank you

@savy-91
Copy link

savy-91 commented Jul 10, 2020

Hi! When is this going to be merged?

@wendux wendux merged commit 8c15919 into cfug:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants