Correct the persistent store behavior #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Funkhouser <christian.funkhouser@gmail.com>
Signed-off-by: Christian Funkhouser <christian.funkhouser@gmail.com>
Signed-off-by: Christian Funkhouser <christian.funkhouser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 42.57% 43.02% +0.45%
==========================================
Files 4 4
Lines 249 251 +2
==========================================
+ Hits 106 108 +2
Misses 129 129
Partials 14 14
Continue to review full report at Codecov.
|
sfunkhouser
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the persistent store accumulated JSON objects each time a refresh was triggered. The proper behavior is to overwrite the file, instead of appending.