Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat code #10

Merged
merged 21 commits into from
Mar 24, 2019
Merged

Reformat code #10

merged 21 commits into from
Mar 24, 2019

Conversation

lxp
Copy link
Member

@lxp lxp commented Mar 21, 2019

See #5

lxp added 20 commits March 13, 2019 01:04
@lxp
Re-format source and fix most issues with PEP-8 compliance
7d08642 
The maximum line length is currently set to an PEP-8 incompatible
length of 200 to avoid awkward line breaks, which make the code
unreadable.
@lxp
Remove unused imports
195a400
@lxp
Use double quotes for all triple-quoted strings
5cdccb7
@lxp
Fix invalid escape sequences in string literals by using raw string l…
bb398ad 
…iterals for regex patterns
@lxp
Use isinstance() instead of type compares
ed97e53
@lxp
Avoid usage of bare except
4852113
@lxp
Replace ambiguous variable names
d241ad6
@lxp
Create namespace from scratch to have module level imports at top of …
7943f7c 
…file
@lxp
Avoid model level imports mid file
4e68422
@lxp
Fix unresolved reference to stderr
0f1827c
@lxp
Avoid mutable default arguments
084dba3
@lxp
Fix initialization of parameter ignore in function copytree
6e44817
@lxp
Add more CI pipeline checks (pyroma, check-manifest, flake8, build, t…
bfa04c8 
…wine check)
@lxp
Install twine before Travis CI check
e71f37f
@lxp
Fix continuation line indentation
4a25aa6
@lxp
Avoid assigned but unused local variables
91b02fb
@lxp
Suppress warnings for unreferenced but required imports
625fc42
@lxp
Add a check to warn on McCabe complexity > 20
6cc5dc5
@lxp
Rise allowed McCabe complexity to the current maximum of 75
32dc3a5 
We would like to be better in the future, but for now we just want
to make sure complexity does not increase.
@lxp
Enable flake8 checks disabled by default
cffbb03
@lxp lxp added this to the 2.0 milestone Mar 21, 2019
@lxp lxp self-assigned this Mar 21, 2019
@lxp lxp merged commit 1d22de0 into master Mar 24, 2019
@lxp lxp changed the title WIP: Reformat code Reformat code Mar 24, 2019
@lxp lxp mentioned this pull request Mar 24, 2019
Closed
@lxp lxp deleted the reformat-code branch March 27, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lxp lxp

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lxp