-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query contains no columns when it has no records #100
Comments
was this working before or is it something that i messed up when trying to get the oracle support working? would you be able to write a test for this? I can then do a bisect and see which commit is the culprit that is causing the regression. |
what database was this on? |
SQL Server. I've added a test for it here: andybellenie@76710fb |
You are the man!
|
looking into this, I don't see this as a bug. When performing a paginated search, the first query passed to the database is just a count seeing if there are any records. If there are no records, then there is no reason to perform the extra work to perform the second query which actually queries the database for the records. |
The second query contains the column list, which is often used to drive functionality. It also means that the result of the query depends on whether or not you enable pagination. |
to me this seems like a non-issue and logic in the findall method is a complete mess. But if you're willing to give it a shot, you have my blessing :) |
I thought you'd say that :) |
hehehe... yes I am evil 😈, but you know I'll be doing some research on this as well. I'll update the ticket with my findings. |
Correct me if I am wrong but this was not an issue on 1.1.8, right? Closing. |
Getting an empty query (no columns) when both a) using pagination (page=1) and the query returns no rows.
The text was updated successfully, but these errors were encountered: