New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB support #563

Closed
AlexeiCF opened this Issue Nov 5, 2015 · 4 comments

Comments

3 participants
@AlexeiCF

AlexeiCF commented Nov 5, 2015

I'm using MariaDB JDBC connector. CFWheels doesn't support it, because it returns MariaDB as an adapter name. MariaDB is fully compatible with MySQL in terms of syntax but is actively developing and has some performance improvements.

I suggest adding support of MariaDB by doing the following:

  1. In wheels/Connection.cfc
    add line 44 to 47
else if (FindNoCase("MariaDB", loc.info.driver_name))
    {
        loc.adapterName = "MariaDB";
    }
  1. Copy-paste and rename wheels/model/adapters/MySQL.cfc -> MariaDB.cfc
@perdjurner

This comment has been minimized.

Contributor

perdjurner commented Nov 6, 2015

If you're just planning to copy and paste the MySQL.cfc without making any changes to it, then it might be better to just accept "MariaDB" as one of the driver names that loads the MySQL.cfc file.

@chapmandu

This comment has been minimized.

Member

chapmandu commented Aug 20, 2016

MariaDB and MySQL are beginning to diverge as of MySQL version 5.7. The MySQL adapter is currently compatible with Maria but this may change in future.

Would it be worth creating a separate adapter or just add Maria to the existing MySQL condition?

@chapmandu

This comment has been minimized.

Member

chapmandu commented Aug 20, 2016

Until there is a significant disparity between engines, the MySQL adapter should suffice.

@chapmandu chapmandu self-assigned this Aug 20, 2016

@chapmandu chapmandu added the backport label Aug 20, 2016

chapmandu added a commit that referenced this issue Aug 20, 2016

chapmandu added a commit that referenced this issue Aug 20, 2016

@chapmandu

This comment has been minimized.

Member

chapmandu commented Aug 20, 2016

@chapmandu chapmandu closed this Aug 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment