New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generated model property labels should drop "ID" from end #618
Comments
chrisdpeters
pushed a commit
that referenced
this issue
Dec 2, 2016
Can we re-open this until the suggested change is complete? |
@andybellenie I tried addressing the issues in your comments on b330990 and couldn't quite get at the info that I needed to inspect associations in that stage of initialization. Would you have any interest in looking at this? |
Ok |
Need to look at this before RC 1. |
Sorry for slow response, not working much atm
I've created a pull request
…On 2 June 2017 at 10:23, Per Djurner ***@***.***> wrote:
Need to look at this before RC 1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#618 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJA90RA7l_1yt72aReWZb_2Jy6qXgrgks5r_9StgaJpZM4H61KA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a property is set up as
userid
, for example, the auto-generated label should be "User," not "User Id."If the column is called
id
, then it should be displayed as "ID" (all caps).I understand that this could lead to some erroneous labels, but I think it would be an edge case. (Trying to think of a word that ends with
id
where it would break:lid
,hid
,amid
,squid
quid
,slid
. Not many examples.) I'm still going to label this as breaking though because there's always something I haven't thought of.The text was updated successfully, but these errors were encountered: