Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated model property labels should drop "ID" from end #618

Closed
chrisdpeters opened this issue Mar 29, 2016 · 5 comments
Closed

Auto-generated model property labels should drop "ID" from end #618

chrisdpeters opened this issue Mar 29, 2016 · 5 comments
Assignees
Milestone

Comments

@chrisdpeters
Copy link
Contributor

If a property is set up as userid, for example, the auto-generated label should be "User," not "User Id."

If the column is called id, then it should be displayed as "ID" (all caps).

I understand that this could lead to some erroneous labels, but I think it would be an edge case. (Trying to think of a word that ends with id where it would break: lid, hid, amid, squid quid, slid. Not many examples.) I'm still going to label this as breaking though because there's always something I haven't thought of.

@andybellenie
Copy link
Contributor

Can we re-open this until the suggested change is complete?

@chrisdpeters chrisdpeters reopened this Dec 6, 2016
@chrisdpeters
Copy link
Contributor Author

@andybellenie I tried addressing the issues in your comments on b330990 and couldn't quite get at the info that I needed to inspect associations in that stage of initialization. Would you have any interest in looking at this?

@andybellenie
Copy link
Contributor

Ok

@perdjurner
Copy link
Contributor

Need to look at this before RC 1.

@perdjurner perdjurner modified the milestones: 2.0.0 RC 1, 2.0.0 Jun 2, 2017
@andybellenie
Copy link
Contributor

andybellenie commented Jun 3, 2017 via email

@perdjurner perdjurner modified the milestones: 2.0.0 Beta 2, 2.0.0 RC 1 Jun 5, 2017
@perdjurner perdjurner modified the milestones: 2.0.0 Beta 2, 2.0.0 RC 1 Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants