Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Python 3.9 #78

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Fixes for Python 3.9 #78

merged 5 commits into from
Jan 5, 2022

Conversation

SimonBiggs
Copy link
Contributor

@SimonBiggs SimonBiggs commented Dec 21, 2021

@cgarciae
Copy link
Owner

cgarciae commented Jan 5, 2022

Hey! Sorry for the delay. So far it looks good, however, black is failing. To fix it run:

black .

and commit changes.

@cgarciae cgarciae closed this Jan 5, 2022
@cgarciae cgarciae reopened this Jan 5, 2022
@cgarciae
Copy link
Owner

cgarciae commented Jan 5, 2022

Didn't mean to close it, wrong button.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #78 (4a7cd52) into master (5231806) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   90.42%   90.34%   -0.09%     
==========================================
  Files          63       63              
  Lines        2267     2279      +12     
==========================================
+ Hits         2050     2059       +9     
- Misses        217      220       +3     
Impacted Files Coverage Δ
pypeln/process/queue.py 93.02% <100.00%> (-3.37%) ⬇️
pypeln/task/queue.py 95.90% <100.00%> (-0.07%) ⬇️
pypeln/thread/queue.py 93.75% <100.00%> (-0.25%) ⬇️
pypeln/utils.py 91.35% <100.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5231806...4a7cd52. Read the comment docs.

@SimonBiggs
Copy link
Contributor Author

Sorry for the delay.

No need to be sorry :)

@cgarciae
Copy link
Owner

cgarciae commented Jan 5, 2022

All good, thanks @SimonBiggs!
Will do a release tonight with the updates.

@SimonBiggs
Copy link
Contributor Author

thanks @SimonBiggs!

My pleasure :)

Will do a release tonight with the updates.

No need to rush on my behalf, I've been installing from my own git branch.

@cgarciae
Copy link
Owner

cgarciae commented Jan 5, 2022

I've been installing from my own git branch.

Nice! I assume its within another poetry project or did poetry figure out how to support pip install git+...?

@SimonBiggs
Copy link
Contributor Author

Yeah a separate poetry project. I put the following in my toml file:

pypeln = { git = "https://github.com/RadiotherapyAI/pypeln", rev = "7727021b4775fb3ec26a84f8fc45547412d23720" }

@SimonBiggs SimonBiggs deleted the python3.9 branch January 6, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TypeError: Multiple inheritance with NamedTuple is not supported Not working with python 3.9
3 participants